angular - Huge performance impact on Component's host document click (Angular2) -


so have 300 instantiations of component defines global click event listener through host property:

@component({   selector: 'value-edit',   template: ``,   host: {     "(document: click)": "onclickoff($event)",   },   changedetection: changedetectionstrategy.onpush ) export class valueeditcomponent {   onclickoff(globalevent) {     // make sure doesn't affect performance keep empty!   } }

i noticed hugely impacts performance, takes 2-3 seconds of processing after every click everywhere on document.

this js cpu profile made in chrome sequence: wait ~5 seconds, click, wait few seconds , stop recording. click huge green column on screenshot:

single click on nothing reactive

i've tried detaching change detector on component or parent didn't help. commenting out line "(document: click)": "onclickoff($event)", fixes problem.

may issue of framework or bad usage i'm not sure how qualify or workaround in more good-practice-way.

plunker here

github issue here

solution / workaround

on angular 2.0.0 (final) code below result in same performance issue:

ngafterviewinit() {     document.addeventlistener('click', evt => this.evtclickhandler) }

registering event outside "zone" should help:

constructor(zone: ngzone) { }  ngafterviewinit() {     this.zone.runoutsideangular(() => {         document.addeventlistener('click', evt => this.offclickhandler(evt))     }) }

explanation

performance issue happened again me using sortablejs library. wasn't case before final version of angular changed due registering events on native elements.

for sortablejs library did this:

this.sortedimages = sortable.create(el, options)

which resulted in bad performance while dragging elements:

enter image description here

solution or workaround goes this:

this.zone.runoutsideangular(() => {   this.sortedimages = sortable.create(el, options) })

where this.zone injected @angular/core/ngzone. way library registers event listeners outside of ngzone.

i have posted an issue on github problem recognized error on coding, not bug in angular. however, changes appeared between latest (rc - before final) versions.

so may bug or (latest) design don't have confirmation on this.


-

Comments

Post a Comment

Popular posts from this blog

unity3d - Rotate an object to face an opposite direction -

i have object , b. when click on object b, rotates object b (a faces b). b doesn't face a. need following : when faces b, need face opposite direction. have code rotating @ b. how rotate face opposite direction after that? vector3 targetdirection = target - transform.position; float step = speed * time.deltatime; vector3 newdirection = vector3.rotatetowards (turretdome.transform.forward, targetdirection, step, 0.0f); turretdome.transform.rotation = quaternion.lookrotation (newdirection); you object facing object b, want inverse direction of object after that? objecta.transform.rotation = quaternion.inverse(objecta.transform.rotation) but lets assume example turretdome object a, (negate direction): turretdome.transform.rotation = quaternion.lookrotation (-newdirection); naturally, both of these snippets not show how smoothen rotation, seem know how use time.deltatime. just incase unsure, quaternion.lerp this
Read more

angular - Is it possible to get native element for formControl? -

i've got angular2 reactive form . created formcontrol s , assigned input fields by [formcontrol]=... . understand creates nativeelement <-> formcontrol link. my question: possible nativeelement formcontrol ? wanna myformcontrol.nativeelement.focus() i can share 1 terrible solution works me. in reactive forms can use either 1) formcontroldirective ts mycontrol = new formcontrol('') template <input type="text" [formcontrol]="mycontrol"> or 2) formcontrolname ts myform: formgroup; constructor(private fb: formbuilder) {} ngoninit() { this.myform = this.fb.group({ foo: '' }); } template <form [formgroup]="myform"> <input type="text" formcontrolname="foo"> </form> so these directives write patch like 1) formcontroldirective const originformcontrolngonchanges = formcontroldirective.prototype.ngonchanges; formcontroldirective.proto
Read more

javascript - Why jQuery Select box change event is now working? -

i working on product filters user select select box according his/her preference not getting selected value user in jquery. html code:- <select name="product_filter" id="product_filter"> <option value="price_low_first">price : low high</option> <option value="price_high_first">price : high low</option> <option value="latest">latest</option> <option value="popular">most popular</option> </select> jquery code: $(function () { $("#product_filter").change(function () { alert("hi") var selectedtext = $(this).find("option:selected").text(); var selectedvalue = $(this).val(); alert("selected text: " + selectedtext + " value: " + selectedvalue); }); }); hi believe code perfect. once please check jquery.min.js
Read more